Record all removed vars in novel_train - #33
Merged
Conversation
rem_var holds every all-zero training feature, but only rem_var[0] was stored, so novel_predict removed one column from the test matrix no matter how many the model had dropped.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
novel_traindrops every all-zero feature from the training matrix:but only hands the first one to
novel_predict:so
novel_predictremoves exactly one column from the test matrix regardless of how many the model dropped. With two or more all-zero features the test matrix is wider than the model expects -- the TF-IDFidfvector no longer broadcasts, ornn.Lineargets the wrong input size on the ADT path:The comment says "Mostly only applicable for testing", but nothing stops a real GEX training split from having several all-zero genes.
Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!